more edge values #14

youknowone · 2026-01-13T13:27:42Z

Summary by CodeRabbit

Tests
- Expanded integer operation test suite with additional edge cases and boundary values
- Increased floating-point test dataset with more edge case values for improved coverage
Chores
- Updated project git ignore rules

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai · 2026-01-13T13:27:53Z

📝 Walkthrough

Walkthrough

The PR expands test coverage by increasing edge case datasets for integer and floating-point operations, and updates the .gitignore to ignore Python-related artifacts. No production logic is modified.

Changes

Cohort / File(s)	Summary
Configuration Update `\.gitignore`	Added "cpython" to ignore rules alongside existing entries.
Test Data Expansion `src/math/integer.rs`, `src/test.rs`	Expanded edge case datasets: EDGE_I64 increased from 24 to 44 elements with boundary values, powers of two, factorial thresholds, and i32/i64 limits; EDGE_VALUES increased from 30 to 64 f64 elements including signaling NaN, subnormals, and trig-related constants.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰✨ Hops through test cases with glee,
New edge cases, forty-four and sixty-three!
Boundaries and limits we'll surely explore,
Coverage grows richer than ever before!
Python ignored, the tests sing with delight! 🧪

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main change—adding more edge case values to test datasets across multiple files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

src/math/integer.rs (1)
718-773: Fix array size mismatch causing compilation failure.

The pipeline failure indicates the array declaration specifies 44 elements but 45 are provided. Update the type to [i64; 45] to match the actual element count.
🐛 Proposed fix
-    const EDGE_I64: [i64; 44] = [
+    const EDGE_I64: [i64; 45] = [

🧹 Nitpick comments (1)

src/test.rs (1)
61-65: Duplicate value in array.

-0.9999999999999999 appears twice: once at line 62 (atanh boundary) and again at line 64 (log1p boundary). Consider replacing one with a distinct value or removing the duplicate to maximize test coverage with unique values.
♻️ Suggested fix - replace duplicate with a distinct value
     // log1p domain boundary (> -1)
-    -0.9999999999999999, // just above -1
+    -0.99999999999999, // slightly further from -1
     -1.0 + 1e-15,        // very close to -1

📜 Review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 97d2f52 and 8313a32.

📒 Files selected for processing (3)

.gitignore
src/math/integer.rs
src/test.rs

🧰 Additional context used

📓 Path-based instructions (3)

src/**/*.rs

📄 CodeRabbit inference engine (AGENTS.md)

Error handling: Return Result directly with Err(crate::Error::EDOM) or Err(crate::Error::ERANGE) instead of using set_errno. Only valid set_errno call is set_errno(0) to clear errno before libm calls.

Files:

src/test.rs
src/math/integer.rs

src/**/*test*.rs

📄 CodeRabbit inference engine (AGENTS.md)

src/**/*test*.rs: All float functions must be tested with crate::test::EDGE_VALUES which includes zeros, infinities, NaNs with different payloads, subnormals, boundary values (MIN_POSITIVE, MAX, MIN), large values near infinity, and trigonometric special values (PI, PI/2, PI/4, TAU).
Tests must verify both correct values for Ok results and correct error types (EDOM vs ERANGE) for Err results. Python ValueError maps to Error::EDOM and OverflowError maps to Error::ERANGE.

Files:

src/test.rs

src/math/**/*.rs

📄 CodeRabbit inference engine (AGENTS.md)

src/math/**/*.rs: Use existing CPython helper equivalents: FUNC1 → math_1(x, func, can_overflow), FUNC2 → math_2(x, y, func), m_log/m_log10/m_log2 in exponential.rs. If CPython uses a helper, use the corresponding Rust helper.
Use crate::mul_add(a, b, c) instead of a * b + c for expressions of the form a * b + c or c + a * b to match CPython's FMA (fused multiply-add) behavior on platforms like macOS where it's enabled.

Files:

src/math/integer.rs

🧠 Learnings (7)

📓 Common learnings

Learnt from: CR
Repo: RustPython/pymath PR: 0
File: AGENTS.md:0-0
Timestamp: 2026-01-10T13:40:01.981Z
Learning: Applies to src/**/*test*.rs : All float functions must be tested with crate::test::EDGE_VALUES which includes zeros, infinities, NaNs with different payloads, subnormals, boundary values (MIN_POSITIVE, MAX, MIN), large values near infinity, and trigonometric special values (PI, PI/2, PI/4, TAU).