feat: error toasts #368
Draft
feat: error toasts #368
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
joshsny
approved these changes
Dec 19, 2025
jonathanlab
commented
Dec 19, 2025
jonathanlab
commented
Jan 14, 2026
| import { ipcRenderer } from "electron"; | ||
| import "electron-log/preload"; | ||
|
|
||
| // No TRPC available, so just use IPC |
Contributor
Author
There was a problem hiding this comment.
(yet). this happens before we initialise TRPC
jonathanlab
commented
Jan 14, 2026
| </Text> | ||
| <Text size="2" color="gray" align="center"> | ||
| {error.message} | ||
| </Text> |
Contributor
Author
There was a problem hiding this comment.
Let's render stack here
jonathanlab
commented
Jan 14, 2026
|
|
||
| const devErrorToastsEnabled = | ||
| IS_DEV && import.meta.env.VITE_DEV_ERROR_TOASTS !== "false"; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Is this consistent with how we set dev in main? I believe not.
jonathanlab
commented
Jan 14, 2026
| error: (message: string, ...args: unknown[]) => log.error(message, ...args), | ||
| debug: (message: string, ...args: unknown[]) => log.debug(message, ...args), | ||
| const devErrorToastsEnabled = | ||
| IS_DEV && import.meta.env.VITE_DEV_ERROR_TOASTS !== "false"; |
Contributor
Author
There was a problem hiding this comment.
this value shouldnt have to be determined in 3 different spots in the code, export to util
jonathanlab
commented
Jan 14, 2026
Comment on lines
+5
to
+24
| interface BaseLog { | ||
| info: LogFn; | ||
| warn: LogFn; | ||
| error: LogFn; | ||
| debug: LogFn; | ||
| scope: (name: string) => { | ||
| info: LogFn; | ||
| warn: LogFn; | ||
| error: LogFn; | ||
| debug: LogFn; | ||
| }; | ||
| } | ||
|
|
||
| export interface ScopedLogger { | ||
| info: LogFn; | ||
| warn: LogFn; | ||
| error: LogFn; | ||
| debug: LogFn; | ||
| scope: (name: string) => ScopedLogger; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
Can we make this simpler?
jonathanlab
commented
Jan 14, 2026
apps/array/vite.main.config.mts
Outdated
| } | ||
|
|
||
| const __dirname = path.dirname(fileURLToPath(import.meta.url)); | ||
| const monorepoRoot = path.resolve(__dirname, "../.."); |
Contributor
Author
There was a problem hiding this comment.
Are we using this for anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes handling errors and warnings easier for our setup.
In development, we now render toasts for uncaught exceptions and unhandled rejections in both renderer and main, preload errors, and trpc query/mutation errors.
We can now also send any toast to the user from the main process via the
user-notificationsservice.I added a react error boundary, not sure if we want to keep this around.