Open
Conversation
Member
Author
|
Or better show MSE? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #473 +/- ##
=======================================
Coverage 75.46% 75.46%
=======================================
Files 62 62
Lines 6895 6895
Branches 1227 1227
=======================================
Hits 5203 5203
Misses 1221 1221
Partials 471 471 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dweindl
approved these changes
Feb 4, 2026
Member
dweindl
left a comment
dweindl
left a comment
There was a problem hiding this comment.
Or better show MSE?
It might be nice to have different options, but I'm not sure what should be the default.
| ax.plot(x, intercept + slope * x, "r", label="fitted line") | ||
|
|
||
| mse = np.mean(np.abs(residual_df["residual"])) | ||
| # assumes that residuals are normalized by default |
Member
There was a problem hiding this comment.
Don't assume, pass normalize=True to calculate_residuals. And maybe move calculate_residuals and msnr computation closer together, so this becomes clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was displayed as Mean squared error, wan't that.
Display Mean of squared normalized residuals instead