Conversation
Make library compatible with pandas 3.0. Closes PEtab-dev#469.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #471 +/- ##
=======================================
Coverage 75.46% 75.46%
=======================================
Files 62 62
Lines 6895 6895
Branches 1227 1227
=======================================
Hits 5203 5203
Misses 1221 1221
Partials 471 471 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
All edits in this file are in repeated code but fine as is
| pd.testing.assert_frame_equal( | ||
| problem.observable_df, observable_df_expected | ||
| problem.observable_df, observable_df_expected, check_dtype=False | ||
| ) |
There was a problem hiding this comment.
Why False? Could add a brief comment.
There was a problem hiding this comment.
Because dataframe dtypes are a mess in petab.v1 :(. Not sure if discussing that there is really helpful. The actual data is still checked, that should be sufficient for this test.
There was a problem hiding this comment.
Ah, makes sense. I thought it was somehow an ironic consequence of the "improved" type checking in this PR.
3 participants
Make library compatible with pandas 3.0.
Closes #469.