Open
Conversation
StephLin
requested changes
Jan 14, 2023
Contributor
StephLin
left a comment
StephLin
left a comment
There was a problem hiding this comment.
Many thanks for your contribution!
The code is almost correct, while there are some programming issues. Please fix them accordingly.
We format our code with Black and lint them with Flake8 in this project. Please checkout here (offline code linting) and here (coding style) for details. Thank you!
| @@ -0,0 +1,36 @@ | |||
| import pylab | |||
| import numpy as np | |||
| from random import * | |||
Contributor
There was a problem hiding this comment.
Prevent using from ... import *.
Suggested change
| from random import * | |
| from random import random |
| map=[[0x8,0x8,0x7f,0x49,0x7f,0x8,0x8],[0x8,0x8,0x3e,0x2a,0x7f,0x14,0x63]] | ||
| R,C=7,7 | ||
| ds=5 | ||
| #m=int(input("> ")) |
| a=2*pi*random() | ||
| sina=np.sin(a) | ||
| cosa=np.cos(a) | ||
| ra=(1/m)*(0.8+0.2*random()) |
Contributor
There was a problem hiding this comment.
Suggested change
| ra=(1/m)*(0.8+0.2*random()) | |
| ra=(1/m)*(2.0+0.2*random()) |
The radius
I think the radius should be enlarged. Like
| #m=int(input("> ")) | ||
| m = 1 | ||
| ds=20 | ||
| pylab.axis("off") |
Contributor
There was a problem hiding this comment.
Suggest adding pylab.axis("equal") for isometric scaling.
Suggested change
| pylab.axis("off") | |
| pylab.axis("off") | |
| pylab.axis("equal") |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.