[fix] 공유하기 브리징 제거 #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughWebView 메시지 처리에서 SHARE 기능이 제거되고, 메시지 타입과 훅의 처리 로직이 단순화되었습니다. 전체 코드베이스에서 쿼트 스타일이 일관되게 정규화되었습니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@types/webview-message.types.ts`:
- Around line 2-7: The WebViewMessageTypes object still includes the obsolete
SHARE entry; remove the SHARE: "SHARE" property from the WebViewMessageTypes
const (and any direct references to WebViewMessageTypes.SHARE) so the runtime
constants match the updated union/type surface and prevent legacy usage—update
or delete any code that still references WebViewMessageTypes.SHARE to use the
new approved message types (e.g., NAVIGATE_BACK, NOTIFICATION_SUBSCRIBE,
NOTIFICATION_UNSUBSCRIBE) or refactor callers to the new API.
Comment on lines
2
to
7
| export const WebViewMessageTypes = { | ||
| NAVIGATE_BACK: 'NAVIGATE_BACK', | ||
| NOTIFICATION_SUBSCRIBE: 'NOTIFICATION_SUBSCRIBE', | ||
| NOTIFICATION_UNSUBSCRIBE: 'NOTIFICATION_UNSUBSCRIBE', | ||
| SHARE: 'SHARE', | ||
| NAVIGATE_BACK: "NAVIGATE_BACK", | ||
| NOTIFICATION_SUBSCRIBE: "NOTIFICATION_SUBSCRIBE", | ||
| NOTIFICATION_UNSUBSCRIBE: "NOTIFICATION_UNSUBSCRIBE", | ||
| SHARE: "SHARE", | ||
| } as const; |
There was a problem hiding this comment.
SHARE 상수 제거로 타입/정책 일관성 유지
SHARE 유니온이 제거됐는데 상수는 남아 있어 레거시 사용이 계속될 수 있습니다. 의도대로면 상수도 제거해 API 표면을 정리하는 편이 안전합니다.
🧹 Proposed fix
export const WebViewMessageTypes = {
NAVIGATE_BACK: "NAVIGATE_BACK",
NOTIFICATION_SUBSCRIBE: "NOTIFICATION_SUBSCRIBE",
NOTIFICATION_UNSUBSCRIBE: "NOTIFICATION_UNSUBSCRIBE",
- SHARE: "SHARE",
} as const;📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| export const WebViewMessageTypes = { | |
| NAVIGATE_BACK: 'NAVIGATE_BACK', | |
| NOTIFICATION_SUBSCRIBE: 'NOTIFICATION_SUBSCRIBE', | |
| NOTIFICATION_UNSUBSCRIBE: 'NOTIFICATION_UNSUBSCRIBE', | |
| SHARE: 'SHARE', | |
| NAVIGATE_BACK: "NAVIGATE_BACK", | |
| NOTIFICATION_SUBSCRIBE: "NOTIFICATION_SUBSCRIBE", | |
| NOTIFICATION_UNSUBSCRIBE: "NOTIFICATION_UNSUBSCRIBE", | |
| SHARE: "SHARE", | |
| } as const; | |
| export const WebViewMessageTypes = { | |
| NAVIGATE_BACK: "NAVIGATE_BACK", | |
| NOTIFICATION_SUBSCRIBE: "NOTIFICATION_SUBSCRIBE", | |
| NOTIFICATION_UNSUBSCRIBE: "NOTIFICATION_UNSUBSCRIBE", | |
| } as const; |
🤖 Prompt for AI Agents
In `@types/webview-message.types.ts` around lines 2 - 7, The WebViewMessageTypes
object still includes the obsolete SHARE entry; remove the SHARE: "SHARE"
property from the WebViewMessageTypes const (and any direct references to
WebViewMessageTypes.SHARE) so the runtime constants match the updated union/type
surface and prevent legacy usage—update or delete any code that still references
WebViewMessageTypes.SHARE to use the new approved message types (e.g.,
NAVIGATE_BACK, NOTIFICATION_SUBSCRIBE, NOTIFICATION_UNSUBSCRIBE) or refactor
callers to the new API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
변경사항
공유하기 기능은 웹뷰에서 web share api에서 처리되기에 브리지 작업이 따로 필요없었습니다.
share 관련 코드를 제거했습니다.
use-webview-message-handler.ts: share 인터페이스 제거 및 case 조건문에서 로직 제거webview-message-types.ts: share 메세지 타입 제거club-detail-screen.tsx: 상세페이지 공유하기 핸들러 제거Summary by CodeRabbit
릴리스 노트
버그 수정
개선 사항
✏️ Tip: You can customize this high-level summary in your review settings.