Update create wallet logic #6069
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SeniorZhai
force-pushed
the
feature/create_wallet_flow
branch
from
c2507d2 to
e06087d
Compare
SeniorZhai
force-pushed
the
feature/create_wallet_flow
branch
from
e06087d to
4b357e2
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request refactors the wallet creation logic from a dialog-based approach to an embedded approach during TIP (Trusted Identity Protocol) setup and login verification. The changes remove the standalone WalletUnlockBottomSheetDialogFragment and integrate wallet creation directly into the TIP registration and login flows.
Changes:
- Removed the standalone wallet unlock dialog UI and its associated ViewModel
- Integrated wallet creation logic into TIP registration flow (TipFragment) and login verification (LoginVerifyBottomSheetDialogFragment via BottomSheetViewModel)
- Updated WalletConnect handling to remove wallet unlock dialog checks and simplified to use centralized wallet creation
- Refactored job classes to remove automatic wallet creation from background sync jobs
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| fragment_wallet_unlock_bottom_sheet.xml | Removed the standalone wallet unlock dialog layout |
| WalletUnlockViewModel.kt | Removed the ViewModel for the wallet unlock dialog |
| WalletUnlockBottomSheetDialogFragment.kt | Removed the dialog fragment for wallet unlocking |
| TipFragment.kt | Added wallet creation logic during TIP registration with address signing |
| BottomSheetViewModel.kt | Added ensureClassicWallet method to create wallet during login verification |
| MainActivity.kt | Updated to check for classic wallet instead of individual addresses |
| WebFragment.kt | Removed wallet unlock dialog invocation (returns early instead) |
| LinkBottomSheetDialogFragment.kt | Removed wallet unlock dialog invocation |
| LoginVerifyBottomSheetDialogFragment.kt | Added call to ensureClassicWallet during login verification |
| WalletConnectV2.kt | Replaced external constants with local constants for chain types |
| RefreshWeb3Job.kt | Removed automatic wallet creation logic from background sync |
| Various job files | Import reordering (formatting changes only) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/src/main/java/one/mixin/android/ui/conversation/link/LinkBottomSheetDialogFragment.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.