Attempt Fix #505 SQL Timings Not Displaying - for ProfiledDbDataAdapt…#658
Open
urbanekv wants to merge 1 commit intoMiniProfiler:mainfrom
Open
Attempt Fix #505 SQL Timings Not Displaying - for ProfiledDbDataAdapt…#658urbanekv wants to merge 1 commit intoMiniProfiler:mainfrom
urbanekv wants to merge 1 commit intoMiniProfiler:mainfrom
Conversation
…dDbDataAdapter.Fill() called with a dataset
|
@NickCraver can we ask for a status of this PR? Is there anything we can do? Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…er.Fill() called with a dataset
Hi @NickCraver , after some exploring, I dared to post this draft. It helped us to solve the problem with missing stats - issue #505
In our project, we use ProfiledDbDataAdapter with the DataSet object passed to the FIll() method . It helped us to get rid of not-well-closed timings. The totals are now filled correctly.