Add MashDark skin

[notnout]

Proposed changes

Adding new dark MashDark skin. This skin is using multiple new features, like styling borders separately and styling default files.

• Refs: Allow styling of borders separately from default files #4553

Checklist

• I have referenced the issue(s) resolved by this PR (if any)
• I have signed-off my contribution with git commit --amend -s
• Lint and unit tests pass locally with my changes (make indent && make check)
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation (if appropriate)

[zyv]

Obsoletes #5005.

[zyv]

Looks nice to me.

[egmontkob]

Generally I quite like it. First few nitpicks:

• Please follow the naming convention of having 256 in the filename. (I don't really like this convention anymore, maybe we can discuss in another ticket to get rid of it for all our skins.)
• Please add new keyword viewboldunderline, can be tested with chacl.1 (#3531).
• There are a few trailing spaces in the file.

Up until last night I thought it was my idea to use rounded corners (1b438db), then realized your skins has had them for years, cool! :)

[egmontkob]

#4974 / #4976 is expected to land soon (a bit of underlying technical refactoring is on the way, not affecting the feature as it'll end up).

If, by any chance, you want to be the first skin specifying any of those three new colors as other than transparent, I think you can go ahead now and add those colors (or wait for a couple of days until that lands).

[egmontkob]

The shadow color is almost invisible (I thought it was actually invisible until I looked up the definition). When there's a popup dialog, let's say Copy file, it essentially chops off parts of some filenames, which can be quite misleading.

Would you please consider making text in the shadow a bit less dark?

Those dark shades of gray are so close to each other. Even after magnifying the screen 8x with gimp and beefing up my screen's brightness to the max, I still literally can't see any difference with my naked eyes, although the color picker indeed confirms a slightly brighter black.

Generally I find the frame, headers etc. quite dark. Still readable, but close to borderline. I think it's an "artistic choice" that you want to de-emphasize the chrome more than other skins do so I'm fine with it. Maybe reusing that same color for the shadow could work better? Or just one step darker? It doesn't really have to be easily readable, but I think it should be hinted that there is something there.

(I know it also depends on the monitor, surrounding light conditions, one's eyes etc... and I'm also blaming standard RGB namespace, and in turn the 256-color cube's grayscale ramp too, for really not being linear to how humans perceive their brightness and contrast. Or is it just me?)

[mc-worker]

#4974 / #4976 is expected to land soon (a bit of underlying technical refactoring is on the way, not affecting the feature as it'll end up).

There are a lot of conflicts with #4995. I think, #4995 should be merged first.

[egmontkob]

There are a lot of conflicts with #4995. I think, #4995 should be merged first.

Sorry, I wasn't explicit on this: yes, this is my plan (this is the underlying technical refactoring I was referring to). First complete 4995, then rebase 4974/4976 on top of that.

For notnout to possibly test this new feature this is irrelevant, he can test the look with #4976's current state, if he's interested in this feature at all.

[notnout]

Thank you for the feedback

• Indeed the borders and other elements are intentionally dark - the specific choice here is to make the files&folders really pop up (with #fff) and have the orange/yellow accent on some main action elements, while other control elements are intentionally dark.
• updated the shadow fg to be more visible
• renamed to add 256 (my suggestion would be to drop this requirement, unless it's meaningfully differentiating the same skin, e.g. if there's both xxx256.ini and xxx16M.ini)
• I introduced some aliases for common colors
• I added viewboldunderline, although I'm not styling it differently at this point
• I would like to style the commandline and hint, but I'd prefer to wait for the final keyword? Or is that clear?

What is the submission process? Do I need to do anything else here other than fixing based on feedback? (this is my first time submitting like this on github, so I'm likely doing something wrong - please let me know)

[egmontkob]

Thanks for the adjustments!

I would like to style the commandline and hint, but I'd prefer to wait for the final keyword? Or is that clear?

I think we've settled on "hintbar", "shellprompt" and "commandline", the ones used by the current state of that PR. (If they'll change, I'll take care of adjusting this skin.)

If you want to skin them (some or all of them), I think the easiest is if we wait for that in this PR.

What is the submission process? Do I need to do anything else here other than fixing based on feedback?

The commits should be squashed, either you can do that, or we can (we do have permissions to push to this branch of yours). After that we'll click the "Merge" button and add a NEWS entry, you don't have to do anything else!

[egmontkob]

renamed to add 256 (my suggestion would be to drop this requirement, unless it's meaningfully differentiating the same skin, e.g. if there's both xxx256.ini and xxx16M.ini)

Filed #5010.

[notnout]

Thank you. I added "hintbar", "shellprompt" and "commandline", just changing the background for now.

[egmontkob]

just changing the background for now

That's not a good idea, it's unreadable if the terminal's basic colors are black on white (as e.g. I prefer it).

[notnout]

Ok, added!
(and I finally set my defaults for git to actually include signoff, sorry for any commit noise)