Open
Conversation
packages/assets-controllers/src/token-prices-service/codefi-v2.ts
Outdated
Show resolved
Hide resolved
gabrieledm
reviewed
Feb 3, 2026
gabrieledm
reviewed
Feb 3, 2026
packages/assets-controllers/src/token-prices-service/codefi-v2.ts
Outdated
Show resolved
Hide resolved
packages/assets-controllers/src/token-prices-service/codefi-v2.ts
Outdated
Show resolved
Hide resolved
mikesposito
reviewed
Feb 3, 2026
|
|
||
| ### Added | ||
|
|
||
| - Add CHZ (0x15b38) mapping to eip155:88888/erc20:0x677f7e16c7dd57be1d4c8ad1244883214953dc47 ([#7794](https://github.com/MetaMask/core/pull/7794)) |
Member
There was a problem hiding this comment.
True that we added an object property, but what we are doing from the perspective of a package consumer is changing the SPOT_PRICES_SUPPORT_INFO exported variable. Should this line go under the CHANGED category?
Member
There was a problem hiding this comment.
hmm actually, the constant I was referring to doesn't seem to be exported by the package, so in theory this change is transparent to consumers
Contributor
There was a problem hiding this comment.
True. What effect does this have on the service class? Were there errors in attempting to use this chain before? Does it change the return type of something? etc.
Contributor
There was a problem hiding this comment.
Similar to my comment in #7688 (comment), what do you think about this?
Suggested change
| - Add CHZ (0x15b38) mapping to eip155:88888/erc20:0x677f7e16c7dd57be1d4c8ad1244883214953dc47 ([#7794](https://github.com/MetaMask/core/pull/7794)) | |
| - `CodefiTokenPricesServiceV2` now supports fetching prices of CHZ on Chiliz Mainnet (chain `0xdef1`) ([#7794](https://github.com/MetaMask/core/pull/7794)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
References
Checklist
Note
Low Risk
Low risk constant/config change that only expands supported chain/asset mappings for price lookups; impact is limited to CHZ pricing on the added chain ID if the mapping is incorrect.
Overview
Adds Chiliz Mainnet native asset support to the token price service by mapping chain ID
0x15b38to the CAIP-19 identifier for CHZ inSPOT_PRICES_SUPPORT_INFO.Updates the
assets-controllerschangelog to document the new CHZ mapping.Written by Cursor Bugbot for commit 2c45fdd. This will update automatically on new commits. Configure here.