fix: install better-sqlite3 for playwright tests#299
Merged
allison-truhlar merged 3 commits intomainfrom Jan 30, 2026
Merged
Conversation
krokicki
reviewed
Jan 27, 2026
Member
krokicki
left a comment
krokicki
left a comment
There was a problem hiding this comment.
Does it need to be installed as a system dependency? Could it be run using Pixi, or using a Typescript wrapper like https://github.com/WiseLibs/better-sqlite3?
If we can avoid system dependencies it will make things more reproducible outside the container, which is nice to have.
…m-installed sqlite3
Collaborator
Author
I made the change to using better-sqlite3 and confirmed all the ui tests now run inside the container. |
allison-truhlar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the failing Playwright tests in the dev container by adding sqlite3 to the Dockerfile. sqlite3 is used to delete tables in the test database after each test run - tables weren't getting deleted so tests had the incorrect starting state. This PR also improves the error message for when deleting tables fails, to distinguish between errors where the table doesn't exist vs other types of errors.
@krokicki