-
Notifications
You must be signed in to change notification settings - Fork 6.7k
Feat agent engine samples #13738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat agent engine samples #13738
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @madhavmadupu, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Python documentation samples for Vertex AI by introducing new examples for the Agent Engine (Reasoning Engine). These samples demonstrate core operations such as creating and deleting Agent Engine instances, and generating memories, providing users with practical, ready-to-use code for integrating this service. Additionally, a minor but important fix was applied to an existing image generation sample to prevent potential errors related to directory creation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds new Python code snippets for Vertex AI Agent Engine, covering creation, memory generation, and deletion. The changes are a good addition, but there are several areas for improvement, particularly in the test suite. The tests currently leak cloud resources and contain an empty test case, which are critical issues to address. Additionally, the new sample code can be improved for better readability and maintainability by adding type hints and simplifying client initialization. My review includes specific suggestions to fix these issues.
|
I have addressed all bot feedback:
The PR is now ready for final human review. Thank you! |
|
Note to reviewer: You may notice that this PR includes a commit ( |
yeesian
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Hi @gericdong and @yeesian, I have updated the PR to address the latest feedback:
The PR should be ready for final review. Thank you! |
|
Can you address the following linter issues (not all of it is introduced by this PR, but it's still required for it to be merged)? The python unit test failure (see below) also seem to suggest that e.g. https://github.com/GoogleCloudPlatform/python-docs-samples/blob/main/generative_ai/reasoning_engine/requirements.txt needs to be updated to more recent versions of |
|
Thanks for pointing those out, @yeesian. I'll address these linter issues and push an update shortly. Working on it! |
- Unpin google-cloud-aiplatform in requirements.txt - Add type hints and cleanup imports in test_agent_engine_examples.py - Fix whitespace in delete_agent_engine.py and generate_memories.py
Description
Fixes #13734
Added new Python code snippets for Vertex AI Agent Engine (Reasoning Engine).
The following operations are covered:
These snippets include the required region tags for documentation integration and have accompanying unit tests in
test_agent_engine_examples.py.Checklist
nox -s py-3.9(see Test Environment Setup)nox -s lint(see Test Environment Setup)