-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add skip validations in vmware cluster #16135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add skip validations in vmware cluster #16135
Conversation
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @shuyama1, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_gkeonprem_vmware_cluster" "primary" {
skip_validations = # value needed
}
|
Tests analyticsTotal tests: 25 Click here to see the affected service packages
🟢 All tests passed! View the build log |
shuyama1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test/ modify an existing test to cover this field? Thanks! https://googlecloudplatform.github.io/magic-modules/reference/resource/#update_url
| - 'STATE_TRUE' | ||
| - 'STATE_FALSE' | ||
| - 'STATE_UNKNOWN' | ||
| - name: skipValidations |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move this field above to the parameters section. Also you'll likely need to modify create_url and probably update_url to include this field
Release Note Template for Downstream PRs (will be copied)
See Write release notes for guidance.