-
Notifications
You must be signed in to change notification settings - Fork 14
remove pytorch from main dep #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughUpdated Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
37-56: Consider cleaning up duplicate dependencies in the webrtc group.While not part of this change, there are several duplicate entries in the
webrtcoptional-dependencies that could cause confusion:
Package Line 1 Line 2 numpy >=2.2.6,<2.3(39)>=2.2.6(48)scipy >=1.15.3,<1.16(41)>=1.15.3(50)protobuf >=4.25.1(43)>=6.31.1(53)websockets >=15.0.1,<16(44)>=15.0.1(54)websocket-client >=1.8.0(45)>=1.8.0(55)The
protobufversions are notably inconsistent (4.25.1 vs 6.31.1). You may want to consolidate these in a follow-up.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: GetStream/stream-py PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-02T12:16:57.243Z
Learning: Applies to **/*.py : Plugins that work with audio, video, or WebRTC functionality should depend on `getstream[webrtc]` instead of just `getstream` to access WebRTC-related dependencies like `aiortc`, `numpy`, `torch`, `torchaudio`, `soundfile`, `scipy`, `deepgram-sdk`, and `elevenlabs`
📚 Learning: 2025-12-02T12:16:57.243Z
Learnt from: CR
Repo: GetStream/stream-py PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-02T12:16:57.243Z
Learning: Applies to **/*.py : Plugins that work with audio, video, or WebRTC functionality should depend on `getstream[webrtc]` instead of just `getstream` to access WebRTC-related dependencies like `aiortc`, `numpy`, `torch`, `torchaudio`, `soundfile`, `scipy`, `deepgram-sdk`, and `elevenlabs`
Applied to files:
pyproject.toml
🔇 Additional comments (1)
pyproject.toml (1)
82-83: The placement oftorchandtorchaudioin dev dependencies is correct. These packages are not—and have never been—part of thewebrtcoptional-dependencies, so moving them here is not a breaking change. They are only used inscripts/create_test_assets.py, and the comment appropriately documents this limitation.Likely an incorrect or invalid review comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
40-56: Pre-existing duplicate dependencies with conflicting versions.The
webrtcextras contain duplicate entries with inconsistent version constraints:
Package First occurrence Second occurrence numpy>=2.2.6,<2.3(line 40)>=2.2.6(line 49)protobuf>=4.25.1(line 44)>=6.31.1(line 54)scipy>=1.15.3,<1.16(line 42)>=1.15.3(line 51)websockets>=15.0.1,<16(line 45)>=15.0.1(line 55)websocket-client>=1.8.0(lines 46, 56)The
protobufconflict (>=4.25.1vs>=6.31.1) is particularly problematic. Consider consolidating these in a follow-up.
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: GetStream/stream-py PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-02T12:16:57.243Z
Learning: Applies to **/*.py : Plugins that work with audio, video, or WebRTC functionality should depend on `getstream[webrtc]` instead of just `getstream` to access WebRTC-related dependencies like `aiortc`, `numpy`, `torch`, `torchaudio`, `soundfile`, `scipy`, `deepgram-sdk`, and `elevenlabs`
📚 Learning: 2025-12-02T12:16:57.243Z
Learnt from: CR
Repo: GetStream/stream-py PR: 0
File: AGENTS.md:0-0
Timestamp: 2025-12-02T12:16:57.243Z
Learning: Applies to **/*.py : Plugins that work with audio, video, or WebRTC functionality should depend on `getstream[webrtc]` instead of just `getstream` to access WebRTC-related dependencies like `aiortc`, `numpy`, `torch`, `torchaudio`, `soundfile`, `scipy`, `deepgram-sdk`, and `elevenlabs`
Applied to files:
pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: unit / Test "not integration"
- GitHub Check: unit / Test "not integration"
- GitHub Check: unit / Test "not integration"
- GitHub Check: unit / Test "not integration"
- GitHub Check: unit / Test "not integration"
- GitHub Check: unit / Test "not integration"
- GitHub Check: unit / Test "not integration"
- GitHub Check: unit / Test "not integration"
🔇 Additional comments (2)
pyproject.toml (2)
83-84: No breaking change — torch and torchaudio are correctly placed in dev dependencies.Verification confirms that
torchandtorchaudioare used exclusively inscripts/create_test_assets.pyand not in any runtime webrtc code. Moving these to dev dependencies is safe and appropriate.Likely an incorrect or invalid review comment.
39-39: LGTM. Pinningav>=14.0.0,<14.3to versions with pre-built wheels is sound.Both av 14.0.0 (Dec 2024) and av 14.2.0 (Feb 2025, latest in 14.x) have prebuilt wheels available for CPython 3.9–3.13 across Windows, macOS, and manylinux platforms. The version constraint successfully targets the intended range and avoids build-time compilation issues.
remove torch since we only use it for dev.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.