refactor: Centralize error output #3902
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… link between GEOS_THROW_CTX_IF and LVARRAY_THROW_IF_TEST( EXP, MSG, TYPE )
… in try/catch statements Problem: Retrieves everything that was thrown, so not just the message.
…/catch in main)": remove useless try/catch
…y spaces. The previous condition checked whether an argument was present and whether the option was immediately followed by a value like -test"value", which excluded valid cases like -test "value" et -test "value".
MelReyCG
requested changes
Jan 8, 2026
src/coreComponents/dataRepository/unitTests/testErrorHandling.cpp
Outdated
Show resolved
Hide resolved
src/coreComponents/dataRepository/unitTests/testErrorHandling.cpp
Outdated
Show resolved
Hide resolved
MelReyCG
reviewed
Jan 12, 2026
MelReyCG
reviewed
Jan 14, 2026
MelReyCG
reviewed
Jan 15, 2026
src/coreComponents/dataRepository/unitTests/testErrorHandling.cpp
Outdated
Show resolved
Hide resolved
MelReyCG
reviewed
Jan 19, 2026
Comment on lines
+399
to
+400
| /// Avoid concurrent access between threads for outputs | ||
| static std::mutex m_errorHandlerMutex; |
Contributor
There was a problem hiding this comment.
I would like to advise a less prohibiting mutex:
- non static to not block between logger instances,
- 1 mutex for each concurrent stream scenario (1 for yaml, 1 for log).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code duplication found in
GEOS_THROW,GEOS_ERROR,GEOS_WARNINGand put into a static function inErrorLogger.Called while
flushErrorMsg().Move all Exceptions under GeosExceptions.hpp