[ Feature ] Multi Tab - License Tab #246
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
chennes
reviewed
Sep 14, 2025
Member
chennes
left a comment
chennes
left a comment
There was a problem hiding this comment.
A few minor comments, below. Also your new code includes blank lines between nearly every line of code, so I don't know if your IDE doesn't like something or what.
for more information, see https://pre-commit.ci
…er into Feature-Tabs
for more information, see https://pre-commit.ci
chennes
reviewed
Sep 24, 2025
Member
|
I'll give this a refactoring pass today or tomorrow -- we shouldn't use a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the work done here
I decided to go with a minimal
approach for my own implementation.
LicensetabHelp wanted, if someone with Python async knowledge
could make this not block the UI, that's be just great ..
Implementation Notes
I decided to have mapping of the tabs to their tab indices
to not have to hard code them and keep them in sync.
The license text is currently just dumped in the
tab, for now I just wanted to get it to work.