feat: prerequisites check step as Step 1 in start #51

redpanda-f · 2026-01-30T06:28:55Z

Created a distinct step PrerequisitesCheckStep before start actually does anything meaningful.

Copilot

Pull request overview

This pull request introduces a dedicated prerequisites check step to validate that all required binaries and Docker images are available before starting the cluster. This improves the fail-fast behavior and provides clearer error messages to users when components are missing.

Changes:

Adds PrerequisitesCheckStep as the first step in the parallel execution startup sequence
Centralizes binary and image checks using new constants REQUIRED_BINARIES and REQUIRED_DOCKER_IMAGES
Removes duplicate image and binary checking logic from the Lotus step

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`src/constants.rs`	Adds `REQUIRED_BINARIES` and `REQUIRED_DOCKER_IMAGES` constants to centralize the list of required components for cluster startup
`src/commands/status/build_status.rs`	Updates to use the shared `REQUIRED_BINARIES` constant instead of maintaining a separate list
`src/commands/start/prerequisites_check.rs`	New module implementing the prerequisites check step with binary and Docker image validation
`src/commands/start/mod.rs`	Adds `PrerequisitesCheckStep` as Epoch 1 in the parallel execution pipeline and updates epoch documentation
`src/commands/start/lotus/prerequisites.rs`	Removes the now-redundant `check_image_and_binary()` function
`src/commands/start/lotus/lotus_step.rs`	Removes the call to the deleted `check_image_and_binary()` function

src/commands/start/prerequisites_check.rs

Copilot · 2026-01-30T06:33:21Z

src/commands/start/prerequisites_check.rs

+    if !missing_binaries.is_empty() {
+        let missing_list = missing_binaries.join("', '");
+        return Err(format!(
+            "Missing required binaries: '{}'\n\nPlease run 'foc-devnet build ...' to build all binaries, \


The error message says "Please run 'foc-devnet build ...' to build all binaries" but this is incorrect syntax. Based on the rest of the message, it should either say "foc-devnet build" (without "...") to build all binaries, or provide the correct command. The ellipsis "..." is confusing as it's not a valid shell command.

Suggested change

"Missing required binaries: '{}'\n\nPlease run 'foc-devnet build ...' to build all binaries, \

"Missing required binaries: '{}'\n\nPlease run 'foc-devnet build' to build all binaries, \

@redpanda-f why was this closed? An all would be great but I don't think we have that, and ... isn't a thing as far as I can tell. Or maybe this error msg could be rephrased? I read it as "run this to build all together, or run this to build them individually".

Issue is I don't want this to be confused with "foc-devnet build" being a command itself.

Co-authored-by: Copilot <[email protected]>

src/constants.rs

rvagg · 2026-01-30T11:08:56Z

src/commands/start/prerequisites_check.rs

+            "Missing required binaries: '{}'\n\nPlease run 'foc-devnet build ...' to build all binaries, \
+             or build specific binaries with 'foc-devnet build <name>' (e.g., 'foc-devnet build lotus' or 'foc-devnet build curio')",


Suggested change

"Missing required binaries: '{}'\n\nPlease run 'foc-devnet build ...' to build all binaries, \

or build specific binaries with 'foc-devnet build <name>' (e.g., 'foc-devnet build lotus' or 'foc-devnet build curio')",

"Missing required binaries: '{}'\n\nPlease build them with 'foc-devnet build <name>' \

(e.g., 'foc-devnet build lotus' or 'foc-devnet build curio')",

let's make it clearer then, I still want there to be a build all, and the lack of something like that makes this message confusing otherwise.

rvagg

approving but assuming that the confusing message will be fixed before merge

BigLep

I'm wondering if:

Any README_ADVANCED.md updates required?
Can we also address #29 as part of this work

BigLep · 2026-01-30T18:33:28Z

src/constants.rs

 pub const PORTAINER_DOCKER_IMAGE: &str = "foc-portainer";

+/// Required binaries for cluster startup
+pub const REQUIRED_BINARIES: &[&str] = &[


Should we also check for Docker as part of #29 ?

BigLep · 2026-01-30T18:34:00Z

src/commands/start/mod.rs

-/// - Epoch 4: MockUSDFC Deploy + MultiCall3 Deploy + FOC Deploy (can be parallelized)
-/// - Epoch 5: MockUSDFC Funding + Curio daemons (can be parallelized, needs FOC Deploy)
-/// - Epoch 6: PDP SP Registration (needs Curio daemons started)
+/// - Epoch 1: Prerequisites check (binaries & Docker images - must run first)


Should the README_ADVANCED.md also get updated?

add: prerequisistes check step as Step 1 in start

3bf027a

Copilot AI review requested due to automatic review settings January 30, 2026 06:28

FilOzzy added this to FOC Jan 30, 2026

github-project-automation bot moved this to 📌 Triage in FOC Jan 30, 2026

Copilot started reviewing on behalf of redpanda-f January 30, 2026 06:29 View session

redpanda-f linked an issue Jan 30, 2026 that may be closed by this pull request

Check for required binaries before allowing start #48

Open

redpanda-f requested a review from rvagg January 30, 2026 06:30

Copilot AI reviewed Jan 30, 2026

View reviewed changes

redpanda-f added this to the M4.0: mainnet staged milestone Jan 30, 2026

Update src/commands/start/prerequisites_check.rs

789e962

Co-authored-by: Copilot <[email protected]>

rvagg reviewed Jan 30, 2026

View reviewed changes

src/constants.rs Show resolved Hide resolved

makehappy: fmt

d6aaa64

rvagg reviewed Jan 30, 2026

View reviewed changes

rvagg approved these changes Jan 30, 2026

View reviewed changes

github-project-automation bot moved this from 📌 Triage to ✔️ Approved by reviewer in FOC Jan 30, 2026

rjan90 assigned redpanda-f Jan 30, 2026

BigLep reviewed Jan 30, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: prerequisites check step as Step 1 in start #51

feat: prerequisites check step as Step 1 in start #51

Uh oh!

redpanda-f commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 30, 2026

Uh oh!

rvagg Jan 30, 2026

Uh oh!

redpanda-f Jan 30, 2026

Uh oh!

Uh oh!

rvagg Jan 30, 2026

Uh oh!

rvagg left a comment

Uh oh!

BigLep left a comment

Uh oh!

BigLep Jan 30, 2026

Uh oh!

BigLep Jan 30, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

	"Missing required binaries: '{}'\n\nPlease run 'foc-devnet build ...' to build all binaries, \
	"Missing required binaries: '{}'\n\nPlease run 'foc-devnet build' to build all binaries, \

		"Missing required binaries: '{}'\n\nPlease run 'foc-devnet build ...' to build all binaries, \
		or build specific binaries with 'foc-devnet build <name>' (e.g., 'foc-devnet build lotus' or 'foc-devnet build curio')",

feat: prerequisites check step as Step 1 in start #51

Are you sure you want to change the base?

feat: prerequisites check step as Step 1 in start #51

Uh oh!

Conversation

redpanda-f commented Jan 30, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

rvagg Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

redpanda-f Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rvagg Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

rvagg left a comment

Choose a reason for hiding this comment

Uh oh!

BigLep left a comment

Choose a reason for hiding this comment

Uh oh!

BigLep Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

BigLep Jan 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants