Folia Support #2848
Draft
Folia Support #2848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Start cleanup of WorldEdit-CLI data versions * Use a record for the data file * Use cassette-deck to download data files rather than bundling Sketchy implementation atm, better will follow - this "works" as-is without any special handling of missing versions. Intention is to get the "next closest version" when it's not available * Fix up build errors * Review changes * Fix a potential race condition
…ilure (EngineHub#2503) * Set clipboard after regen to prevent unnecessary clipboard loss on failure * Remove the cast
…gineHub#2502) * Add a #match mask, to mask to blocks that match the clipboard * Rename the parser mask to #clipboard * Fix import order * Add documentation to the MatchMask class * PR review feedback * add #copy as an alias * use native Java List.of
* Deprecate bundled item data * Use forRemoval further, and add the extra suppressions necessary due to this
…neHub#2676) * Add a Full Cube mask to mask to blocks that fill an entire cube * IntelliJ is bad * fixes from review
* wip * do all platforms but bukkit & cli * use the paperweight adapters for material information on bukkit * Move bundled block data load to CLI * Drop this part, let it load when needed * Stray warning suppression * Swap to using an MC utility function for full block detection
* Improve reliability of tree generator function * Reimplement TreePlanter using generator
* Add a replacebiome command * Make mask required * Few minor tweaks to formatting/strings * Remove the warning message because it confuses people, and is no longer true on any platform
This also ensures any overriden methods are used for equality or hashcode checks
* Re-implement backing state maps This uses a single array combined with efficiently computed indexes to avoid needing to do entire map equality comparisons or hold large hash-based tables, improving memory and CPU usage. * Give a good error message on property mismatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a thoroughly tested version of WorldEdit against Folia. Not only does it introduce the fundamentals that other forks have offered, but it also provides the ability to utilize
-etags, butchering entities, and even the//regencommand on Spigot, Paper, and Folia alike. That said, this pull request is ready for review, so critical changes (if needed) can be made to ensure Folia is sufficient and prepared for WorldEdit upstream.Supersedes: #2379
Resolves: #2348
This was also done for FastAsyncWorldEdit: IntellectualSites/FastAsyncWorldEdit#3363