Badge component #178
Open
Badge component #178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ealmloff Happy New Year The test, as I understand it, fails because the new component isn't in the main branch. |
ealmloff
requested changes
Jan 8, 2026
Member
ealmloff
left a comment
ealmloff
left a comment
There was a problem hiding this comment.
Thanks for working on this. I would like to support something closer to shadcn's badge component in the component library that generalizes outside of notifications which would require some changes
Contributor
Author
|
@ealmloff I've made changes according to all the requests. To maintain the functionality of the first version, I've separated the "Notifications" component into a separate type (based on the Badge). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plan
Fixes #72