This repository was archived by the owner on Apr 28, 2020. It is now read-only.
Allow loading mods from version-specified directory i.e. mods/rift/1.13/#65
Open
k-jiang wants to merge 7 commits intoDimensionalDevelopment:masterfrom
Open
Allow loading mods from version-specified directory i.e. mods/rift/1.13/#65k-jiang wants to merge 7 commits intoDimensionalDevelopment:masterfrom
k-jiang wants to merge 7 commits intoDimensionalDevelopment:masterfrom
Conversation
0f-0b
reviewed
Nov 17, 2018
ZombieHDGaming
suggested changes
Nov 17, 2018
create "mods/rift/" folder by default Rift's mods should be inside "mods/rift/" or "mods/rift/_version_", no more "mods/_version_-Rift/" load mods from classpath, "mods/rift/_version_", "mods/rift/" and "mods/" classpath mods are now loaded and logged separately to avoid confusion
Author
|
OK, I modify the loading process, now the logic is:
The reason why I chose lower-case for "rift" is to eliminate any case-sensitive scenario and confusion, just like forge. Any ideas? |
0f-0b
suggested changes
Nov 18, 2018
0f-0b
left a comment
0f-0b
left a comment
There was a problem hiding this comment.
Suggest changes for readability and performance.
Fix case sensitive. Co-Authored-By: k-jiang <k@kjiang.net>
Improve readability. Co-Authored-By: k-jiang <k@kjiang.net>
0f-0b
approved these changes
Nov 18, 2018
k-jiang
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let Rift to try loading mods form the
mods/"version"-Riftfolder. If empty, fall back to "mods/" instead.p.s. I removed the "final" flag from variable
modsDir, not sure if there are any consequences.