-
Notifications
You must be signed in to change notification settings - Fork 52
add reference tables function #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
To do: add tests and deal with GEOPANDAS message. Done 12/22/25. |
thodson-usgs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve, but see the comment about logging a warning rather than info. I think the former is correct, because we are warning the user that a module is missing so some functionality may be absent.
I'm still not sure how I feel about the built-in logging module, but once you started printing out lots of API information, it was necessary to introduce finer control over the logging settings. Not every use will want to be bombarded with that stuff.
Co-authored-by: Timothy Hodson <[email protected]>
|
Thanks for the review, @thodson-usgs. I hear you on the logging. I like knowing how many requests I have left (and it mimics R dataRetrieval), but I understand that that's not everyone's preference, and I could see how it might be annoying in CI jobs and such. I like this solution for now, but happy to revisit if you have other ideas. |
This PR adds the reference metadata tables to the package.
Addresses #196 and #204