⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@ehinman
Copy link
Collaborator

@ehinman ehinman commented Dec 19, 2025

This PR adds the reference metadata tables to the package.

Addresses #196 and #204

@ehinman
Copy link
Collaborator Author

ehinman commented Dec 19, 2025

To do: add tests and deal with GEOPANDAS message. Done 12/22/25.

@ehinman ehinman marked this pull request as ready for review December 22, 2025 19:41
@ehinman ehinman requested a review from thodson-usgs December 22, 2025 19:42
Copy link
Collaborator

@thodson-usgs thodson-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, but see the comment about logging a warning rather than info. I think the former is correct, because we are warning the user that a module is missing so some functionality may be absent.

I'm still not sure how I feel about the built-in logging module, but once you started printing out lots of API information, it was necessary to introduce finer control over the logging settings. Not every use will want to be bombarded with that stuff.

@ehinman
Copy link
Collaborator Author

ehinman commented Jan 14, 2026

Thanks for the review, @thodson-usgs. I hear you on the logging. I like knowing how many requests I have left (and it mimics R dataRetrieval), but I understand that that's not everyone's preference, and I could see how it might be annoying in CI jobs and such. I like this solution for now, but happy to revisit if you have other ideas.

@ehinman ehinman merged commit 67444e5 into DOI-USGS:main Jan 14, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants