feat (JobDB): pydantic datetime validation #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryuwd
changed the title
chrisburr
reviewed
Apr 14, 2025
chrisburr
reviewed
Apr 14, 2025
Contributor
Author
|
I believe most of this is superseded by #479 but it would be worth keeping the pydantic validators, maybe even expanding the pydantic validation to ensure this doesn't get messed up easily again |
Contributor
|
@ryuwd is this PR still needed? |
Contributor
Author
|
This can probably be kept but it needs to be adapted after various fixes were made. I will get around to it soon |
ryuwd
force-pushed
the
roneil-fix-joblogging-offset
branch
from
c02fb80 to
92d7943
Compare
ryuwd
changed the title
ryuwd
changed the title
ryuwd
force-pushed
the
roneil-fix-joblogging-offset
branch
from
92d7943 to
74e9829
Compare
ryuwd
changed the title
ryuwd
force-pushed
the
roneil-fix-joblogging-offset
branch
from
5451048 to
7c449e4
Compare
simplify validator [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
ryuwd
force-pushed
the
roneil-fix-joblogging-offset
branch
from
7c449e4 to
acc2e3c
Compare
Contributor
Will be planned in a sprint (not the next one because @ryuwd will be busy with the LHCb week but may be the one after). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Validate provided datetimes to check they are aware and convert them to UTC if needed.