Merged
Conversation
NicksWorld
force-pushed
the
refactor/hotkey_module
branch
from
ab79524 to
b5d8899
Compare
ab9rf
reviewed
Nov 20, 2025
Contributor
|
Lua API should make it easier to test most of the hotkey surface. |
ab9rf
reviewed
Nov 20, 2025
ab9rf
reviewed
Nov 20, 2025
dhthwy
reviewed
Nov 20, 2025
NicksWorld
force-pushed
the
refactor/hotkey_module
branch
from
8a8ac10 to
43ecdad
Compare
NicksWorld
force-pushed
the
refactor/hotkey_module
branch
from
1ab8893 to
68e0d5b
Compare
NicksWorld
changed the title
NicksWorld
force-pushed
the
refactor/hotkey_module
branch
from
00fb481 to
b89d747
Compare
Member
|
resolving the merge with #5659 is more complex than i can do via the web editor and so i'm not doing it right away |
ab9rf
reviewed
Dec 5, 2025
library/include/modules/Hotkey.h
Outdated
| }; | ||
| } | ||
| class DFHACK_EXPORT HotkeyManager { | ||
| friend class Core; |
ab9rf
reviewed
Dec 5, 2025
|
|
||
| PluginManager *getPluginManager() { return plug_mgr; } | ||
| HotkeyManager *getHotkeyManager() { return hotkey_mgr; } | ||
| PluginManager* getPluginManager() const { return plug_mgr; } |
ab9rf
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reworks the hotkey support currently present in Core into a separate module for all related functionality. A number major changes/additions have been made during my rework: