Fix issue with resourcedetection processor failing with no detectors … #4392
+858
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjmoore4
reviewed
Jan 26, 2026
| logfile string, | ||
| ) { | ||
| var spec *v1beta1.InstrumentationLogsSpec | ||
| if inCluster != nil && inCluster.Spec.Instrumentation != nil { |
Contributor
There was a problem hiding this comment.
❓ Same question as above.
| outConfig *Config, | ||
| ) { | ||
| var spec *v1beta1.InstrumentationLogsSpec | ||
| if inCluster != nil && inCluster.Spec.Instrumentation != nil { |
…set. Minor refactoring of some collector code. Add/adjust tests for different otel detector configs.
tjmoore4
approved these changes
Jan 27, 2026
dsessler7
force-pushed
the
otel-resource-detection-fix
branch
from
b7417f6 to
85629a9
Compare
tjmoore4
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…set.
Minor refactoring of some collector code.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
We want to move to the newest version of the opentelemetry-collector-contrib, however, there was a change with the
resourcedetectionprocessor where having zero detectors set results in zero "successes" which results in a failure, killing the collector:open-telemetry/opentelemetry-collector-contrib@50cd2e8
We therefore need to change our code so that we only add the
resourcedetectionprocessor if we have detectors set.What is the new behavior (if this is a feature change)?
We only add the
resourcedetectionprocessor to collector pipelines if there are detectors set in thepostgrescluster/pgadminmanifests. Allows us to move to otel v0.144.0.Other Information: