⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

London | 25-SDC-July | Fatma Arslantas | Sprint 1 | Can't log in from profile page #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AFatmaa wants to merge 1 commit into
base: main
Choose a base branch
from
Open

London | 25-SDC-July | Fatma Arslantas | Sprint 1 | Can't log in from profile page #65

AFatmaa wants to merge 1 commit into from

Conversation

@AFatmaa
Copy link

@AFatmaa AFatmaa commented Dec 30, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I fixed the bug where users could not log in from the profile page.

  • I changed the event listener to listen for the submit event on the form, instead of the click event on the button. This prevents the error.

Questions

I don’t have any questions, thank you.

@AFatmaa AFatmaa added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Dec 30, 2025
@AFatmaa AFatmaa mentioned this pull request Dec 30, 2025
Open
illicitonion
illicitonion reviewed Jan 20, 2026
View reviewed changes
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm - I'm not sure about this - why I ran your code locally and followed the repro instructions on #6 I saw the same error. Did you follow the precise instructions? Can you maybe how a short video of you reproducing the problem before your change and not reproducing it after?

@illicitonion illicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 20, 2026
@illicitonion
Copy link
Member

illicitonion commented Jan 20, 2026

My apologies, I had a caching issue locally - this looks great to me, well done!

@illicitonion illicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illicitonion illicitonion illicitonion left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

Purple Forest Kanban
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AFatmaa @illicitonion