London | 25-SDC-July | Mikiyas Gebremichael | Sprint 1 | New Feature - Follow/Unfollow #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Report: Can't log in from profile page 🔗 Steps to reproduce: Load site with sample data populated. Log in as sample / sosecret Click on a username (e.g. AS) in a bloom shown in the timeline Click logout Log in as sample / sosecret Expect to see: A logged in view of AS’s profile, with a “Logout” button in the top-right. Actually see: A 501 error page saying “Server does not support this operation.” :gear: bug DONE now
…characters! But AS has a bloom which is longer than that! Not fair! => This bug is fixed now
… link doesn't work correctly, When loading the populated data, the user Swiz’s second bloom (which reads “Let’s get some #SwizBiz love!!”) has weird hashtag links. If you click the word “#SwizBiz” it takes you to an empty page which doesn’t show any blooms. I would expect at least the bloom I clicked the link in to be shown, and also perhaps any others containing the hashtag. On the other hand, in their other bloom (“New album dropping at midnight! Pre-save now! #SwizBiz”), clicking on “#SwizBiz” does take you to exactly what I expect - a page showing blooms containing #SwizBiz including the one I clicked from.
…n for checking if the current hashtag is there we dont need to fetch its own data. makes sense
Mikiyas-STP
added
📅 Sprint 1
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
There seems to be quite a lot of unrelated changes in this PR? Please can you remove them so this PR only does one thing?
Comment on lines
+176
to
+189
| #Extract content safely | ||
| content = request.json.get("content", "") | ||
| # Limit content length | ||
| MAX_BLOOM_LENGTH = 280 | ||
| if len(content) > MAX_BLOOM_LENGTH: | ||
| return make_response( | ||
| { | ||
| "success": False, | ||
| "message": f"Bloom cannot exceed {MAX_BLOOM_LENGTH} characters", | ||
| }, | ||
| 400, | ||
| ) | ||
|
|
||
| blooms.add_bloom(sender=user, content=request.json["content"]) | ||
| blooms.add_bloom(sender=user, content=content) |
Member
There was a problem hiding this comment.
This change seems unrelated to the PR? Can you revert it?
illicitonion
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR is done for the new feature implementation -Follow/ Unfollow button
Questions
No question