ZA | 25-SDC-JULY | Luke Manyamazi | Sprint 1 | Extra Long Bloom #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Luke-Manyamazi
added
📅 Sprint 1
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This generally looks good! One extra note I have is that the number 280 is appearing in a lot of places in this code, so if you wanted to change it to 300 you'd need to change it in a lot of places - can you think how to reduce this duplication?
Comment on lines
+21
to
+22
| if len(content) > 280: | ||
| content = content[:280] # truncate to 280 characters |
Member
There was a problem hiding this comment.
Automatically truncating works (and you have endpoint-layer checks to make sure we shouldn't get here), but it's not clear whether at the DB layer we should truncate or reject - what do you think the trade-offs are here?
illicitonion
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Added validation in send_bloom() route to reject content exceeding 280 characters.
Updated bloom.py model to handle content truncation safely when inserting new blooms.
Added database cleanup step (SQL) to truncate existing blooms longer than 280 characters.
Improved error response messages for better feedback when validation fails.
Questions
None