Pass intercom app id in environment for Grunt build #1685
Pass intercom app id in environment for Grunt build #1685
Conversation
| } else { | ||
| INTERCOM_APP_ID = 'xs5g95pd'; // test ID | ||
| } | ||
| INTERCOM_APP_ID = process.env.INTERCOM_APP_ID || 'xs5g95pd'; |
There was a problem hiding this comment.
There is no processEnv here. Needs to be something in a JSON file that's generated. Did you e2e this for overriding the appID?
There was a problem hiding this comment.
I tested this locally. Does the e2e cover this?
There was a problem hiding this comment.
I mean setting the intercom app id to "foo" for example. and we don't really have any e2e that works, just meant doing manual end to end testing
There was a problem hiding this comment.
Simply put, serviceEventTracking should not have process.env....
tosih
force-pushed
the
add_intercom_app_id_as_env
branch
from
9f0afd8 to
2c47d66
Compare
|
So I tried deploying it to gamma, and the intercom bubble doesn't show up |
tosih
force-pushed
the
add_intercom_app_id_as_env
branch
from
8aada44 to
dcd669d
Compare
layout.jade
Outdated
| src = "https://widget.intercom.io/widget/xs5g95pd" | ||
| ) | ||
| script( | ||
| src = "https://widget.intercom.io/widget/" + intercomAppId |
There was a problem hiding this comment.
I'm unsure if this bit will work. Does it?
There was a problem hiding this comment.
Shouldnt it be
script(src="https://widget.intercom.io/widget/#{locals.intercomAppId}")
SAN-5016 Close Popover when Sidebar is closed
…the status of the config.
…copy Changed copy
Stop unique events when user clicks buttons.
SAN-5036 Popover Display Logic
SAN-5072 Toggling Auto Launch - Changes Guide Level
Fixed terminal page disabling
…d-to-all-interfaces
SAN-5071 Hide Toggle Sidebar
Error when checking dockerfile paths
…rong Repo updated dates were wrong
add 2 user min copy
add disabled styles for back arrow
Fix for deleting Container Files
Please enter the commit message for your changes. Lines starting
Fixed getAllBranches to get more pages.
SAN-5027 Allow user to exit milestone 3
…into SAN-5100-setup-confirmation-modal-style
…al-style Setup confirmation modal is too high
9 participants
Dependencies