Conversation
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| createRoot(document.getElementById("root")!).render( |
There was a problem hiding this comment.
Not sure if this is a Vite thing or a React thing, but typescript-eslint doesn't like the non-null-assertion here. For this case I think it is fine to have, and removing it is more work than it's worth, so I think it's fine to ignore the linter here.
This rule may only be on because I turned strict checks on for tseslint, but we can always turn those off if it becomes a problem down the line.
ashstewart7
left a comment
ashstewart7
left a comment
There was a problem hiding this comment.
LGTM, excited to be getting started on this!
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| createRoot(document.getElementById("root")!).render( |
package.json
Outdated
| "preview": "vite preview" | ||
| }, | ||
| "dependencies": { | ||
| "react": "^18.3.1", |
There was a problem hiding this comment.
React 19 was released a few weeks ago, let's upgrade to use that version.
There was a problem hiding this comment.
I don't think this needed to be a hard blocker on the PR, but I agree we should use the newest version of React.
Looks like the npm create vite@latest command hasn't been updated to use React 19 yet. I'll make the change.
3 participants
Closes #2
Included is the initial scaffold for the site: