Split regional historical recipes into model and reference runs #460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
bouweandela
force-pushed
the
split-regional-historical-recipes
branch
from
563b49b to
79c96fd
Compare
bouweandela
force-pushed
the
split-regional-historical-recipes
branch
from
bbdb54b to
fda40b4
Compare
bouweandela
force-pushed
the
split-regional-historical-recipes
branch
from
ad31ec8 to
a8fd54b
Compare
bouweandela
commented
Feb 5, 2026
| if not isinstance(requirement, DataRequirement): | ||
| raise TypeError(f"Expected a DataRequirement, got {type(requirement)}") | ||
| if requirement.source_type not in data_catalog: | ||
| raise InvalidDiagnosticException( |
Contributor
Author
There was a problem hiding this comment.
The test cases fail with this exception because they are run with a catalog that only contains CMIP6 or obs4MIPs data, not both, so I downgraded this to a debug message.
Contributor
There was a problem hiding this comment.
That is fine. I think this isn't possible for a user using the CLI
Contributor
Author
There was a problem hiding this comment.
It happens when I run ref test-cases run --provider esmvaltool
Contributor
There was a problem hiding this comment.
Ahh yup I meant a solve, but I also bumped into this in #510 so definitely a bug
lewisjared
approved these changes
Feb 5, 2026
| if not isinstance(requirement, DataRequirement): | ||
| raise TypeError(f"Expected a DataRequirement, got {type(requirement)}") | ||
| if requirement.source_type not in data_catalog: | ||
| raise InvalidDiagnosticException( |
Contributor
There was a problem hiding this comment.
That is fine. I think this isn't possible for a user using the CLI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Split regional historical recipes into model and reference runs and preprocess all regions in one go. This avoids loading the data multiple times and rerunning relatively expensive computations to compute the reference for each model. The downside is that the plots created by ESMValTool now will only contain the model or reference, so it is up to the REF portal to create a series figure where both are visible.
Checklist
Please confirm that this pull request has done the following:
changelog/