Conversation
serprex
approved these changes
Dec 9, 2025
The format of the `pg_clickhouse.session_settings` GUC was
key = val, key = 'val'...
But that doesn't match options passed to `CREATE SERVER` and the like,
which requires space, not an equal sign, between option names and
values:
key val, key 'val'...
In the future we'll want to merge these options with the GUC, so it's
better if they use the same format.
So add a new parameter to `chfdw_parse_options()`, `bool with_equal`,
and only require an equal sign between the name and value when it't
true. Then change calls to it to not require a comma for the GUC, but to
still require them for the `clickhouse_raw_query()` connection string,
to align with the libpq behavior.
Update the GUC tests and documentation to reflect this change.
Add support for JSONB to `INSERT` statements and, when importing tables, map the ClickHouse JSON type to PostgreSQL JSONB. This increases the what users can do with these values; they can still use JSON for manually-created tables. Does not yet include binary engine support for JSON, which will requires support from clickhouse-cpp (ClickHouse/clickhouse-cpp#450).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for JSONB to
INSERTstatements and, when importing tables, map the ClickHouse JSON type to PostgreSQL JSONB. This increases the what users can do with these values; they can still use JSON for manually-created tables.Does not yet include binary engine support for JSON, which will requires support from clickhouse-cpp (ClickHouse/clickhouse-cpp#450).