⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Fix Euclid catalogs link#244

Open
troyraen wants to merge 2 commits intomainfrom
raen/issues/243/euclid-xref
Open

Fix Euclid catalogs link#244
troyraen wants to merge 2 commits intomainfrom
raen/issues/243/euclid-xref

Conversation

@troyraen
Copy link
Contributor

@troyraen troyraen commented Feb 6, 2026

Resolves #243

Thanks for spotting this @bsipocz

@troyraen troyraen requested a review from bsipocz February 6, 2026 19:27
@troyraen troyraen added bug Something isn't working documentation Improvements or additions to documentation content: euclid Content related issues/PRs for notebooks with Euclid relevance labels Feb 6, 2026
This tutorial is an introduction to the content and format of the Euclid Q1 Merged Objects HATS Catalog.
Later tutorials in this series will show how to load quality samples.
See [Euclid Tutorial Notebooks: Catalogs](../../euclid_access/euclid.md#catalogs) for a list of tutorials in this series.
See [Euclid Tutorial Notebooks](../../euclid_access/euclid.md) for a complete list of Euclid tutorials.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you better not rely on relative paths. I see why you would prefer to use filepaths instead of references to link to other notebooks, but we don't ship the landing pages into fornax, and one may just open up a notebook on its own, so this link with be broken in those cases anyway.

And using a path will make it more likely to break when things are moved around. And IMO the hover preview can be useful for links like this as opposed to a link that takes the user away from their notebook (compare the preview here with the version we have on the website right now).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good point that we don't ship the landing pages to fornax. I think I'll just remove this line entirely.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cross links like this could still be useful for the HTMLs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of the way we've decided to set up the landing page, the link I wanted to put here doesn't exist, and the generic "all Euclid tutorials" that I'd have to use instead is not nearly as helpful here. It's ok that the link I wanted doesn't exist. But I think it's better to just remove this line.

Re: the larger question of whether to use xrefs or relative paths, l thought we had come to a consensus a couple of months ago that relative paths are preferable in notebooks repos because they work in all the same important places that xrefs do and they also work in a couple other important places where xrefs don't. It sounds like I misunderstood your position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working content: euclid Content related issues/PRs for notebooks with Euclid relevance documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: Cross reference target was not found: catalogs

2 participants