Firefly-1936: clean up obscore/datalink titles and refactor most to a single file

[robyww]

Firefly-1936: Clean up obscore/datalink titles and refactor most to a single file

• Move most title computation to one file
• add support for datalink description field if it is usable (include usability test)
• Fixed: issue with titles that changed after a part is analyzed.
• IRSA-7247: fixed

Testing:

• SPHEREx: https://firefly-1936-titles.irsakubedev.ipac.caltech.edu/applications/spherex
• Euclid: https://firefly-1936-titles.irsakubedev.ipac.caltech.edu/applications/euclid
• Firefly: https://fireflydev.ipac.caltech.edu/firefly-1936-titles/firefly

[lrebull]

low-key minor menu placement weirdness

video1362293883.mp4

[lrebull]

i don't know why i kept saying 'right' when i clearly meant 'left' ... and it does seem to be related to the length of the filename...?

[robyww]

@lrebull the menu is shifted because is it so wide now that it uses a different layout approach. The normal is right if it fits, it it does not then it goes left. If you made your browser wider it would probably go back to the right.

[jaladh-singhal]

Tested spherex - the ancillary products dropdown looks much cleaner now. I didn't notice Luisa's issue, drodown is always on the right for me - likely because I'm using my large monitor over laptop screen.

Code seems fine - left some minor comments.

[jaladh-singhal]

Suggested change

	'This is a web page or web application. It can be open in another tab',
	'This is a web page or web application. It can be opened in another tab',

small typo

[jaladh-singhal]

This can be improved for readability using object destructing and overriding syntax - the positional arguments obscure what is being overridden. title and dropdownText can be made even less redundant in each case:

Suggested change

	const result= (title,dropDownText,message='',loadInBrowserMsg=undefined) =>
	({title,dropDownText,message,loadInBrowserMsg});
	const otMsg= makeObsTitleExtension(obsTitle);
	switch (fileType) {
	case Format.PNG : return result(
	`${title??''}${otMsg} (PNG image)`,
	title ? `${title}${otMsg} (PNG image)` : undefined);
	case Format.JSON : return result(
	'Show JSON file'+otMsg,
	title ? `${title}${otMsg} (JSON File)` : undefined);
	case Format.YAML : return result(
	'Show yaml file'+otMsg,
	title ? `${title}${otMsg} (YAML File)` : undefined);
	const otMsg= makeObsTitleExtension(obsTitle);
	const defaultResult = (fileLabel) =>
	({title: `Show ${fileLabel}`+otMsg,
	dropDownText: title ? `${title}${otMsg} (${fileLabel})` : undefined,
	message: '',
	loadInBrowserMsg: undefined
	});
	switch (fileType) {
	case Format.PNG : return ({
	...defaultResult('PNG image'),
	title: `${title??''}${otMsg} (PNG image)`,
	});
	case Format.JSON : return ({
	...defaultResult('JSON File'),
	// if you decide to change default in future
	});
	case Format.YAML : return ({
	...defaultResult('YAML File'),
	// if you decide to change default in future
	});

[robyww]

good suggestion. I was not that happy this this code for that reason.