⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

FIREFLY-1919: Add support for UWS jobs that produce non-table results#1907

Open
loitly wants to merge 1 commit intodevfrom
FIREFLY-1919-jobs-with-mixed-results
Open

FIREFLY-1919: Add support for UWS jobs that produce non-table results#1907
loitly wants to merge 1 commit intodevfrom
FIREFLY-1919-jobs-with-mixed-results

Conversation

@loitly
Copy link
Contributor

@loitly loitly commented Feb 4, 2026

This PR add the ability to handle UWS job results other than tables (e.g., images). It introduces dynamic loading based on MIME types and add support for multi-result jobs.
It uses the original search request to process the job, and a configured loader to load the results to the UI based on its MIME type.
In cases where a job produces multiple results, a new selection popup allows the user to choose which result to load.

Tests:
https://firefly-1919-jobs-with-mixed-results.irsakubedev.ipac.caltech.edu/irsaviewer/
https://firefly-1919-jobs-with-mixed-results.irsakubedev.ipac.caltech.edu/applications/spherex/
https://firefly-1919-jobs-with-mixed-results.irsakubedev.ipac.caltech.edu/applications/euclid/

Verified that all existing background job worked as before. Pay extra attention to TAP, IRSA Catalog, Euclid, and SPHEREx SP Tool.

Normally, this operation returns a single table.

To test with a single-image FITS file:

To test multi results:

  • Go to Multi-archive VO TAP
  • Select CADC -> any table with any search parameters.
  • Click Search
  • Either wait for monitor in Job Monitor.
  • Show results will popup a list of available results to load.

@loitly loitly force-pushed the FIREFLY-1919-jobs-with-mixed-results branch 2 times, most recently from 0c9c1b8 to 05a6451 Compare February 5, 2026 21:04
@loitly loitly force-pushed the FIREFLY-1919-jobs-with-mixed-results branch from 05a6451 to b0b9be6 Compare February 5, 2026 21:26
@loitly loitly requested review from kpuriIpac and robyww and removed request for robyww February 5, 2026 21:46
@loitly loitly self-assigned this Feb 5, 2026
@loitly loitly added this to the 2026.1 milestone Feb 5, 2026
@loitly loitly marked this pull request as ready for review February 5, 2026 21:47
Copy link
Contributor

@robyww robyww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good and single image results work great.

However, the UI for the multi response is not right. We should talk about what it the best way to proceed. Ultimately we want a TAP search like CADC (and rubin?) to work just like before. So I am not sure how to expose the other results. Let's talk about it in the standup on Monday.

const jobUrl = report?.parts[0].url;
const req = makeTblRequest('UwsJob', title, {jobUrl});
dispatchTableSearch(req);
dispatchTableSearch(req, {backgroundable: true});
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants