Dynamic classes are not overqualified#613
Open
ovanderzee wants to merge 1 commit intoCSSLint:masterfrom
Open
Conversation
…ecify in addition to the unseen styles of the framework
Contributor
|
I don't think hardcoding the Angular prefixes like this is the way to go. Maybe an array property for excluded prefixes + a loop would work? Can you give an example of when the .ng-hide would need adjusting on an element level? I would expect that if you want to add custom styling, that you'd add an extra class in Angular. Also please rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Frameworks like angular-js create dynamic classes like ng-hide that might require styling other than the styles from the frameworks stylesheet. Since the framework style sheet is not linted the combination ".ng-hide {...} a.ng-hide {...}" is not excluded from a warning.
This request will prevent unsound recommendations like: "WARNING: Element (li.ng-leave) is overqualified, just use .ng-leave without element name...".