Fix overflowing add codegen, plus other fixes based on test output#32
Open
calc84maniac wants to merge 3 commits intoz80from
Open
Fix overflowing add codegen, plus other fixes based on test output#32calc84maniac wants to merge 3 commits intoz80from
calc84maniac wants to merge 3 commits intoz80from
Conversation
…from emitting overflowing adds/subs twice
…as 24-bit when possible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
16-bit and 24-bit overflowing add now correctly generates ADC instead of ADD to obtain the overflow flag output. Additionally, the code generation for overflowing and extended add/sub has been updated to avoid performing the calculation twice when both the value and flag outputs are used.
In some cases, condition folding would generate fallback code even when the caller had its own fallback implementation, causing redundant instruction output. This has also been fixed by adding a parameter to indicate no fallback should be emitted when condition folding fails.
While looking at test output, I also identified and fixed the following issues: