⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

feat(abstract-lightning): make valueMsat optional add valueSat support #7966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidkaplanbitgo merged 1 commit into from
Jan 23, 2026
+10 −15
Merged

feat(abstract-lightning): make valueMsat optional add valueSat support #7966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 9 additions & 12 deletions modules/abstract-lightning/src/codecs/api/invoice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,18 +18,12 @@ export const InvoiceStatus = t.union(
);
export type InvoiceStatus = t.TypeOf<typeof InvoiceStatus>;

export const CreateInvoiceBody = t.intersection(
[
t.type({
valueMsat: BigIntFromString,
}),
t.partial({
memo: t.string,
expiry: t.number,
}),
],
'CreateInvoiceBody'
);
export const CreateInvoiceBody = t.partial({
valueMsat: BigIntFromString,
valueSat: t.number,
memo: t.string,
expiry: t.number,
});
export type CreateInvoiceBody = t.TypeOf<typeof CreateInvoiceBody>;

/**
Expand All @@ -52,6 +46,9 @@ export const Invoice = t.intersection(
updatedAt: DateFromISOString,
}),
t.partial({
// Keep valueSat for backward compatibility with older versions of the API
// Will be moved up to required fields in the future
valueSat: t.number,
memo: t.string,
amtPaidMsat: BigIntFromString,
}),
Expand Down
4 changes: 1 addition & 3 deletions modules/express/test/unit/lightning/lightningInvoiceRoutes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,7 @@ describe('Lightning Invoice Routes', () => {
});
req.bitgo = bitgo;

await should(handleCreateLightningInvoice(req)).be.rejectedWith(
/^Invalid request body to create lightning invoice/
);
await should(handleCreateLightningInvoice(req)).be.rejected();
});
});

Expand Down
Loading