Fix: updated map search to account for state#144
Open
NightFury742 wants to merge 1 commit intoBitByte-TPC:masterfrom
Open
Fix: updated map search to account for state#144NightFury742 wants to merge 1 commit intoBitByte-TPC:masterfrom
NightFury742 wants to merge 1 commit intoBitByte-TPC:masterfrom
Conversation
garg3133
reviewed
Jun 1, 2024
| def mapSearch(request): | ||
| location = request.GET.get('search', '') | ||
| city = location.split(',', 1)[0] | ||
| state= location.split(',')[1].strip() |
Member
There was a problem hiding this comment.
This will throw an IndexError if split only generates a list of 1 length. state should be set to '' if no state is passed.
| profiles = profiles.order_by('name') | ||
| else: | ||
| profiles = Profile.objects.filter(city=city) | ||
| profiles = Profile.objects.filter(city="") |
Member
There was a problem hiding this comment.
This returns an empty QuerySet, right?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue: #126
Description:
This PR fixes the discrepancies in the profiles shown on the result page due to same city name.
The map search now accounts for state along with city to filter out profiles effectively.