⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@rickyrombo
Copy link
Contributor

Annoyingly, I think the saga actually makes sense for this rather than playing with useEffects etc.

  • The toast only runs on web, so maybe belongs outside the shared hook
  • The toast should only happen when not on the upload page
  • The toast requires getting the permalink from the fetched entity

I think there's probably a better way and we can work to reduce sagas generally but this makes sense to me for now

@changeset-bot
Copy link

changeset-bot bot commented Feb 2, 2026

⚠️ No Changeset found

Latest commit: 2363b7d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants