⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@lesandie
Copy link
Member

@lesandie lesandie commented Jan 29, 2026

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

S3Queue auxiliary Zookeeper support using keeper_path setting from s3Queue (ClickHouse#95203 by @lesandie)

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions
Copy link

github-actions bot commented Jan 29, 2026

Workflow [PR], commit [0a57259]

@lesandie lesandie self-assigned this Jan 29, 2026
@lesandie lesandie marked this pull request as draft January 29, 2026 15:09
Copy link

@ianton-ru ianton-ru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, same as #1356

Copy link
Collaborator

@zvonand zvonand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test_storage_s3_queue/test_0.py::test_streaming_to_many_views is detected as flaky.

it is likely that it has something to do with the PR that has "S3Queue" in the title 😄

@lesandie lesandie marked this pull request as ready for review January 30, 2026 15:05
@chatgpt-codex-connector
Copy link

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@lesandie lesandie force-pushed the s3_queue_aux_zk branch 2 times, most recently from a29ac5f to 0a57259 Compare January 30, 2026 16:46
@Selfeer
Copy link
Collaborator

Selfeer commented Feb 4, 2026

Failed Jobs Analysis

Job Status Cause PR-Related
Regression release s3_aws_s3_2 error Job did not complete (infrastructure) ❌ No
Regression aarch64/release aggregate_functions_1 failure uniqTheta test needs changes unrelated to the pr ❌ No
Regression aarch64/release s3_aws_s3_2 failure An issue has been identified and resolved upstream; we are currently awaiting its merge and backport. ❌ No
Regression aarch64/release s3_azure_2 failure An issue has been identified and resolved upstream; we are currently awaiting its merge and backport. ❌ No
Regression aarch64/release s3_minio_2 failure An issue has been identified and resolved upstream; we are currently awaiting its merge and backport. ❌ No

────────────────────────────────────────

Detailed Failure Analysis

  1. uniqTheta aggregate function test

• Reports: x86_64 | aarch64
• Reason: Aggregate function test completely unrelated to StorageDistributed directory parsing changes
• Verdict: Test needs to be updated because of the other changes made in upstream related to aggregate functions.

  1. Zero-copy replication tests:

Failed tests across AWS S3, Azure, and MinIO backends:
• zero copy replication/add remove replica parallel
• zero copy replication/add remove one replica
• zero copy replication/bad detached part

The issue: #1338
The fix: ClickHouse#95597

Reports:
s3_aws_s3_2 x86_64
s3_minio_2 x86_64
s3_azure_2 x86_64

  1. Job completion error (INFRASTRUCTURE)

• Regression release s3_aws_s3_2 - "Job did not complete"
• Reason: CI infrastructure issue
• Verdict: Infrastructure problem, not caused by PR

test_streaming_to_many_views - Known Flaky Test

The test_streaming_to_many_views failures (including all parameterized variants) are known flaky tests on the 25.8 branch:

Failures by Version (Last 8 weeks):

Branch/Version Total Failures Unique PRs
antalya-25.8 380 38
releases/25.8.14 117 12
releases/25.8.15 108 14
releases/25.8.13 87 15
master 2 1

Key Evidence:

  • 652 total failures of [ordered] variant across 89 unique PRs in last 8 weeks
  • 333 total failures of [unordered] variant across 86 unique PRs in last 8 weeks
  • Almost exclusively affects 25.8 branches - only 2 failures on master in 16 weeks
  • Consistent 40-140 failures per week on 25.8 branch

You can see the number if fails on different versions in our results database

@Selfeer Selfeer added the verified Verified by QA label Feb 4, 2026
@zvonand zvonand merged commit bf7dba0 into releases/25.8.15 Feb 4, 2026
870 of 1022 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants