⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

25.8.15 Backport of #88090: Optimize ReplacingMergeTree is_deleted FINAL queries by adding a filter expression transform#1332

Merged
zvonand merged 3 commits intoreleases/25.8.15from
backports/25.8.15/88090
Jan 28, 2026
Merged

25.8.15 Backport of #88090: Optimize ReplacingMergeTree is_deleted FINAL queries by adding a filter expression transform#1332
zvonand merged 3 commits intoreleases/25.8.15from
backports/25.8.15/88090

Conversation

@zvonand
Copy link
Collaborator

@zvonand zvonand commented Jan 22, 2026

Changelog category (leave one):

  • Performance Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

SELECT query with FINAL clause on a ReplacingMergeTree table with the is_deleted column now executes faster because of improved parallelization from 2 existing optimizations (ClickHouse#88090 by @shankar-iyer)

CI/CD Options

Exclude tests:

  • Fast test
  • Integration Tests
  • Stateless tests
  • Stateful tests
  • Performance tests
  • All with ASAN
  • All with TSAN
  • All with MSAN
  • All with UBSAN
  • All with Coverage
  • All with Aarch64
  • All Regression
  • Disable CI Cache

Regression jobs to run:

  • Fast suites (mostly <1h)
  • Aggregate Functions (2h)
  • Alter (1.5h)
  • Benchmark (30m)
  • ClickHouse Keeper (1h)
  • Iceberg (2h)
  • LDAP (1h)
  • Parquet (1.5h)
  • RBAC (1.5h)
  • SSL Server (1h)
  • S3 (2h)
  • Tiered Storage (2h)

shankar-iyer and others added 2 commits January 22, 2026 17:31
…with_filter

Optimize ReplacingMergeTree is_deleted FINAL queries by adding a filter expression transform
@github-actions
Copy link

github-actions bot commented Jan 22, 2026

Workflow [PR], commit [7e5f3c5]

@zvonand
Copy link
Collaborator Author

zvonand commented Jan 28, 2026

S3 fails: Altinity/clickhouse-regression#93

Aggregate fails: uniqTheta was updated in upstream, not related, test will be updated separately by QA team

Stateless unrelated

@zvonand zvonand merged commit 6a66616 into releases/25.8.15 Jan 28, 2026
584 of 618 checks passed
@DimensionWieldr
Copy link
Collaborator

DimensionWieldr commented Feb 3, 2026

CI Failure Analysis

1. DCO Check

Failure: Commits lack Signed-off-by: lines

Verdict: Missing sign-off lines are not problems with the PR.


2. Regression Tests (aggregate_functions_1, S3 suites) - Pre-existing Failures

Failures: /aggregate functions/part 1/uniqTheta, /s3/*/part 2/zero copy replication/*

Evidence these are pre-existing on base branch (releases/25.8.15) MasterCI #21579463803:

  • AggregateFunctions (1) = failure
  • S3 (aws_s3, 2) = failure
  • S3 (azure, 2) = failure
  • S3 (minio, 2) = failure

Verdict: Pre-existing failures on base branch. Unrelated to PR changes.


3. Infrastructure Timeouts - CI Runner Issues

Failures: 7 jobs failed with ~10m1s runtime and empty failed steps (BuzzHouse amd_tsan, Integration tests amd_tsan 3/6, Stateless tests amd_msan/tsan, Stress test amd_ubsan)

Root cause: Jobs timed out at infrastructure level before tests could execute.

Verdict: CI infrastructure timeouts. Unrelated to PR changes.


4. Stateless tests (amd_asan, flaky check) - Infrastructure

Failure: failure: Start ClickHouse Server

Verdict: CI infrastructure issue during server initialization. Unrelated to PR changes.


5. New Fails Identified by CI

Test Job Analysis
03174_exact_rows_before_aggregation arm_binary, sequential Test does not use SELECT ... FINAL. PR only modifies spreadMarkRangesAmongStreamsFinal(). Zero code path overlap.
03100_lwu_09_different_structure amd_tsan, s3 storage, parallel Test uses OPTIMIZE TABLE FINAL (storage merge). PR modifies SELECT ... FINAL (query execution). Different code paths.

Additional evidence for 03174:

Verdict: Both tests cannot be affected by this PR - verified via code path analysis.


Summary

Test Category Failure Type Related to PR?
DCO Missing sign-off No
Regression (8 jobs) Pre-existing failures No
Infrastructure (7 jobs) Job timeouts No
Flaky check Server startup No
03174_exact_rows_before_aggregation Flaky (no code path overlap) No
03100_lwu_09_different_structure Flaky (different code path) No

Verdict: All failures are unrelated to the PR changes.

@DimensionWieldr DimensionWieldr added the verified Verified by QA label Feb 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants