⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

[Common] Clean remaining usage of PIDResponse.h #14438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
njacazio merged 1 commit into from
Jan 24, 2026
Merged

[Common] Clean remaining usage of PIDResponse.h #14438

njacazio merged 1 commit into from
Jan 24, 2026
+0 −47

Conversation

@njacazio
Copy link
Collaborator

@njacazio njacazio commented Jan 9, 2026

  • Using PIDResponseTOF and PIDResponseTPC

@github-actions
Copy link

github-actions bot commented Jan 9, 2026 •
edited
Loading

O2 linter results: ❌ 157 errors, ⚠️ 7 warnings, 🔕 0 disabled

@github-actions github-actions bot changed the title Clean remaining usage of PIDResponse.h [Common,DPG,Tutorial,PWGCF,PWGDQ,PWGEM,PWGLF,PWGUD] Clean remaining usage of PIDResponse.h Jan 9, 2026
@alibuild alibuild mentioned this pull request Jan 9, 2026
Merged
njacazio pushed a commit that referenced this pull request Jan 9, 2026
@alibuild
Please consider the following formatting changes to #14438 (#14439)
3a5e17e
@njacazio njacazio force-pushed the njacazio-patch-clean-pidresponse branch from 3a5e17e to fe4a497 Compare January 9, 2026 09:40
@njacazio njacazio marked this pull request as ready for review January 12, 2026 16:57
@njacazio
Copy link
Collaborator Author

njacazio commented Jan 21, 2026

@mcoquet642 @victor-gonzalez @ddobrigk @alcaliva let me ping you. Let's make this happen :)

@alcaliva alcaliva enabled auto-merge (squash) January 21, 2026 13:54
@njacazio njacazio disabled auto-merge January 21, 2026 15:04
@njacazio njacazio enabled auto-merge (squash) January 21, 2026 15:04
victor-gonzalez
victor-gonzalez approved these changes Jan 21, 2026
View reviewed changes
Copy link
Collaborator

@victor-gonzalez victor-gonzalez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njacazio Thanks!!!

@alibuild
Copy link
Collaborator

alibuild commented Jan 22, 2026

Error while checking build/O2Physics/o2 for 8308a2f at 2026-01-22 22:58:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/14438-slc9_x86-64/0/PWGLF/Tasks/Resonances/f0980analysis.cxx:23:10: fatal error: Common/DataModel/PIDResponse.h: No such file or directory
ninja: build stopped: subcommand failed.

Full log here.

This was referenced Jan 23, 2026
Merged
Merged
Merged
Merged
Merged
@njacazio
Clean remaining usage of PIDResponse.h
18bd199 
- Using PIDResponseTOF and PIDResponseTPC
@njacazio njacazio force-pushed the njacazio-patch-clean-pidresponse branch from 8308a2f to 18bd199 Compare January 23, 2026 20:38
@njacazio njacazio changed the title [Common,DPG,Tutorial,PWGCF,PWGDQ,PWGEM,PWGLF,PWGUD] Clean remaining usage of PIDResponse.h [Common] Clean remaining usage of PIDResponse.h Jan 23, 2026
@njacazio njacazio merged commit a25198b into master Jan 24, 2026
11 of 16 checks passed
@njacazio njacazio deleted the njacazio-patch-clean-pidresponse branch January 24, 2026 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@rolavick rolavick rolavick approved these changes

@iarsene iarsene iarsene approved these changes

@omvazque omvazque omvazque approved these changes

@dsekihat dsekihat dsekihat approved these changes

@alcaliva alcaliva alcaliva approved these changes

@romainschotter romainschotter romainschotter approved these changes

@glromane glromane glromane approved these changes

@skundu692 skundu692 skundu692 left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@pbuehler pbuehler Awaiting requested review from pbuehler

@amatyja amatyja Awaiting requested review from amatyja

@mikesas mikesas Awaiting requested review from mikesas

@rbailhac rbailhac Awaiting requested review from rbailhac

@ivorobye ivorobye Awaiting requested review from ivorobye

@feisenhu feisenhu Awaiting requested review from feisenhu

@mpuccio mpuccio Awaiting requested review from mpuccio

@gbencedi gbencedi Awaiting requested review from gbencedi

@abmodak abmodak Awaiting requested review from abmodak

@fmazzasc fmazzasc Awaiting requested review from fmazzasc

@maciacco maciacco Awaiting requested review from maciacco

@dmallick2 dmallick2 Awaiting requested review from dmallick2

@smaff92 smaff92 Awaiting requested review from smaff92

@ercolessi ercolessi Awaiting requested review from ercolessi

@lucamicheletti93 lucamicheletti93 Awaiting requested review from lucamicheletti93 lucamicheletti93 is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@zchochul zchochul Awaiting requested review from zchochul

@lgraczykCern lgraczykCern Awaiting requested review from lgraczykCern

@prchakra prchakra Awaiting requested review from prchakra

@lauraser lauraser Awaiting requested review from lauraser

@ariedel-cern ariedel-cern Awaiting requested review from ariedel-cern

@otonvd otonvd Awaiting requested review from otonvd

@shouqiye shouqiye Awaiting requested review from shouqiye

@noferini noferini Awaiting requested review from noferini

@mfaggin mfaggin Awaiting requested review from mfaggin

@iouribelikov iouribelikov Awaiting requested review from iouribelikov

@lbariogl lbariogl Awaiting requested review from lbariogl

@chiarazampolli chiarazampolli Awaiting requested review from chiarazampolli

@catalinristea catalinristea Awaiting requested review from catalinristea

@ktf ktf Awaiting requested review from ktf ktf is a code owner

@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner

@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner

Assignees

No one assigned

Labels

common datamodel pwgdq

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.