⚠ This page is served via a proxy. Original site: https://github.com
This service does not collect credentials or authentication data.
Skip to content

Conversation

@Houwie7000
Copy link
Collaborator

@Houwie7000 Houwie7000 commented Dec 4, 2025

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • LHCfills page now has a total run duration filter.

Notable changes for developers:

  • GetAllLhcFillsUseCase.js will now execute a JOIN on statistics (fill_statistics) when runDuration and runDurationOperator are defined in the filter.

Changes made to the database:
-None.

@Houwie7000 Houwie7000 requested a review from isaachilly December 4, 2025 13:18
@Houwie7000 Houwie7000 self-assigned this Dec 4, 2025
@Houwie7000 Houwie7000 added frontend backend javascript Pull requests that update Javascript code labels Dec 4, 2025
@codecov
Copy link

codecov bot commented Dec 4, 2025

Codecov Report

❌ Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 41.79%. Comparing base (9e3bc30) to head (a04fac2).

Files with missing lines Patch % Lines
...onents/Filters/LhcFillsFilter/runDurationFilter.js 0.00% 4 Missing ⚠️
lib/usecases/lhcFill/GetAllLhcFillsUseCase.js 57.14% 3 Missing ⚠️
...ws/LhcFills/ActiveColumns/lhcFillsActiveColumns.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                                Coverage Diff                                 @@
##           feature/O2B-1505/lhcfills-beam-duration-filter    #2038      +/-   ##
==================================================================================
- Coverage                                           45.38%   41.79%   -3.59%     
==================================================================================
  Files                                                1031     1032       +1     
  Lines                                               17168    17179      +11     
  Branches                                             3123     3125       +2     
==================================================================================
- Hits                                                 7791     7180     -611     
- Misses                                               9377     9999     +622     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Houwie7000 Houwie7000 force-pushed the feature/O2B-1505/lhcfills-beam-duration-filter branch from 23dbb7b to 11c1f9d Compare December 8, 2025 14:15
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1506/lhcfills-run-duration-filter branch 2 times, most recently from fd1be9f to 2c6fee8 Compare December 8, 2025 15:21
@Houwie7000 Houwie7000 marked this pull request as ready for review December 9, 2025 14:54
@Houwie7000 Houwie7000 requested a review from graduta as a code owner December 9, 2025 14:54
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1505/lhcfills-beam-duration-filter branch from 5c9fecd to 950022d Compare December 11, 2025 11:20
@Houwie7000 Houwie7000 force-pushed the feature/O2B-1506/lhcfills-run-duration-filter branch from 2982915 to 6f77e0c Compare December 16, 2025 09:36
@Houwie7000 Houwie7000 marked this pull request as ready for review December 16, 2025 09:36
Houwie7000 and others added 25 commits December 17, 2025 11:02
…ature/O2B-1506/lhcfills-run-duration-filter

update from upstream
…ature/O2B-1506/lhcfills-run-duration-filter

update from upstream
…ature/O2B-1506/lhcfills-run-duration-filter

update from upstream
Base automatically changed from feature/O2B-1505/lhcfills-beam-duration-filter to main January 21, 2026 14:41
…fills DTO. QueryBuilder WhereAssociationQueryBuilder has been changed to handle associations with an OR operator. Added tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

3 participants