[#3447] fix(frontend): resolve commit modal loading indefinitely #3546
+218
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit modal could hang indefinitely when committing from the variant drawer because it waited for selectedVariantsAtom to include the new revision. That atom is local selection state and does not update when the committed revision was not already selected. Changes: - Add a bounded 1.5s settle timeout so the modal never waits forever - Only wait for selection update when the committed revision was selected - Update the variant drawer to navigate to the new revision on success Closes #3447
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
dosubot
bot
added
size:L
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The commit modal waited for
selectedVariantsAtomto include the new revision before closing. This atom is local selection state (stored in localStorage) and only updates when the UI explicitly sets it. When committing from the variant drawer (where the revision may not be in the playground selection), the modal would wait forever.Solution
Research
See
docs/design/commit-loading-stall/for detailed analysis of the root cause and design decisions.Testing
Deployed and tested on worktree at http://144.76.237.122:8280
Closes #3447