Add visibility to __construct method in example

[jlnarvaez]

Purpose of this pull request

This pull request (PR) add the correct visibility for the example adding a factory in __construct method.

Affected pages

• https://developer.adobe.com/commerce/php/development/components/factories/

[jeff-matthews]

Thanks for the contribution @jlnarvaez!

When the scope of a function is not defined, it defaults to public, right? Is there a reason to set the scope to public?

https://www.php.net/manual/en/language.oop5.visibility.php#language.oop5.visiblity-methods

[jlnarvaez]

Yes, the default is public, this is true, but the recommendetion by PSR-12 is:

Visibility MUST be declared on all methods.

(https://www.php-fig.org/psr/psr-12/#44-methods-and-functions)

[jeff-matthews]

Thanks for clarifying @jlnarvaez.

This will need to wait until we update the coding standard in #141.

[jlnarvaez]

@jeff-matthews if not merged yet, this is a inherited standard from the current (and deprecated) standard PSR-2: https://www.php-fig.org/psr/psr-2/#43-methods

[jeff-matthews]

@jlnarvaez, aha! I see. Thank you for clarifying. I'll go ahead and merge this then.