diff --git a/devel/execute_on_all_databases.sh b/devel/execute_on_all_databases.sh index 99e80e06..dd04e931 100755 --- a/devel/execute_on_all_databases.sh +++ b/devel/execute_on_all_databases.sh @@ -7,7 +7,7 @@ fi . ./devel/all_dbs.sh || exit 2 for db in $all do - for sql in $* + for sql in "$@" do echo "Execute script '$sql' on '$db' database" ./devel/db.sh psql "$db" < "$sql" || exit 2 diff --git a/devel/execute_on_all_databases_k8s.sh b/devel/execute_on_all_databases_k8s.sh index 24d03aa4..4fc8ff9d 100755 --- a/devel/execute_on_all_databases_k8s.sh +++ b/devel/execute_on_all_databases_k8s.sh @@ -34,7 +34,7 @@ fi . ./devel/all_dbs.sh || exit 2 for db in $all do - for sql in $* + for sql in "$@" do echo "Execute script '$sql' on '$db' database" kubectl exec -in "devstats-${kenv2}" "${member}" -- psql "$db" < "$sql" diff --git a/devel/mass_update.sh b/devel/mass_update.sh index 5638d3d3..db5d3ca8 100755 --- a/devel/mass_update.sh +++ b/devel/mass_update.sh @@ -10,7 +10,7 @@ then echo "You need to set TO, example FROM=abc TO=xyz $0 ./some_dir/*" exit 2 fi -for f in $* +for f in "$@" do ls -l "$f" # vim --not-a-term -c "%s/${FROM}/${TO}/g" -c "wq!" "$f" diff --git a/git-lfs-diff.sh b/git-lfs-diff.sh index caf631c7..8405e6cb 100755 --- a/git-lfs-diff.sh +++ b/git-lfs-diff.sh @@ -19,10 +19,10 @@ object() { return fi - Oid=$(git show $Rev:$File 2> /dev/null | grep "sha256" | cut -d ":" -f 2) + Oid=$(git show "${Rev}:${File}" 2> /dev/null | grep "sha256" | cut -d ":" -f 2) if [ "$Oid" != "" ]; then - Oid12=$(echo $Oid | cut -b 1-2) - Oid34=$(echo $Oid | cut -b 3-4) + Oid12=$(echo "$Oid" | cut -b 1-2) + Oid34=$(echo "$Oid" | cut -b 3-4) Object=.git/lfs/objects/$Oid12/$Oid34/$Oid if [ ! -e "$Object" ]; then echo "Missing file $File at revision $Rev" @@ -34,14 +34,14 @@ object() { } -ObjectA=$(object $RevA $File) +ObjectA=$(object "$RevA" "$File") EC="$?" if [ "$EC" != "0" ]; then echo "$ObjectA" exit "$EC" fi -ObjectB=$(object $RevB $File) +ObjectB=$(object "$RevB" "$File") EC="$?" if [ "$EC" != "0" ]; then echo "$ObjectB" diff --git a/util_sh/monitor_command.sh b/util_sh/monitor_command.sh index 5869ce61..ac738561 100755 --- a/util_sh/monitor_command.sh +++ b/util_sh/monitor_command.sh @@ -34,7 +34,7 @@ then fi # Run command, store pid as $pid -( $* ) & pid=$! +( "$@" ) & pid=$! # Spawn watcher that waits TIMEOUT seconds and then kills command gracefully via kill -HUP, store watcher pid as $wather ( sleep $TIMEOUT && kill -HUP $pid ) 2>/dev/null & watcher=$!